Make FormControlLabel.tsx ssr compatible #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially makes old code a bit more inefficent when using typography directly as label, but sadly there is no way of reliably checking what the
isTypography
test for, because we have just access to an html string, which would be even more inefficent to parse it as just wrapping everything in a div.And when someone wants to be as efficent they have to just set the
disableTypography
prop. In my opinion it's a worth tradeoff.