This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Do not sniff mime types #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
force-pushed
the
do-not-sniff-mimetypes
branch
2 times, most recently
from
8de6fd2 to
173388d
Compare
Instead rely on the Content-Type header (remote resources) and the file extension (local resources) to identify SVG images. This removes the dependency on the file tool and on libmagic, and also the entire magic module, which simplifies the code and the build a bit, and removes a runtime dependency. It also effectively enables SVG images on Windows which so far did mostly not work because Windows neither includes the file tool nor libmagic, so users had to go out of their way and install file/libmagic to get SVG images support on Windows.
swsnr
force-pushed
the
do-not-sniff-mimetypes
branch
from
173388d to
2e7ca7b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead rely on the Content-Type header (remote resources) and the file extension (local resources) to identify SVG images. This removes the dependency on the file tool and on libmagic, and also the entire magic module, which simplifies the code and the build a bit, and removes a runtime dependency.
It also effectively enables SVG images on Windows which so far did mostly not work because Windows neither includes the file tool nor libmagic, so users had to go out of their way and install file/libmagic to get SVG images support on Windows.