Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the Language Server restart when related config options are changed #122

Closed
alcarney opened this issue Feb 25, 2021 · 0 comments · Fixed by #133
Closed

Have the Language Server restart when related config options are changed #122

alcarney opened this issue Feb 25, 2021 · 0 comments · Fixed by #133
Assignees
@alcarney
Labels
enhancement New feature or request ide:vscode Issues that relate to the Esbonio vscode extension

Comments

@alcarney
Copy link
Member

Should be possible with the onDidChangeConfiguration notification
@alcarney alcarney added enhancement New feature or request ide:vscode Issues that relate to the Esbonio vscode extension labels Feb 25, 2021
@alcarney alcarney self-assigned this Mar 1, 2021
@alcarney alcarney mentioned this issue Mar 1, 2021
Merged
alcarney added a commit that referenced this issue Mar 1, 2021
@alcarney
Quality of life improvements (#133)
e4215a9 
- The extension now enforces a minimum Language Server version, will give the option of upgrading the server if an old version is detected. Closes #123 
- The extension will now automatically restart the Language Server when the extension's configuration is updated. Closes #122 
- If `esbonio.server.logLevel` is set to `debug` the extension assumes the user is working on the Language Server and will automatically open the log panel on restarts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alcarney alcarney

Labels
enhancement New feature or request ide:vscode Issues that relate to the Esbonio vscode extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quality of life improvements alcarney/esbonio
1 participant
@alcarney