Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language server offers role target completions outside of a role #77

Closed
alcarney opened this issue Jan 29, 2021 · 0 comments · Fixed by #76
Closed

Language server offers role target completions outside of a role #77

alcarney opened this issue Jan 29, 2021 · 0 comments · Fixed by #76
Labels
bug Something isn't working lsp Issues that relate to the language server

Comments

@alcarney
Copy link
Member 

say you have a :ref:`reference`, the server would incorrectly offer completions here 
                                                                                    ^
@alcarney alcarney added bug Something isn't working lsp Issues that relate to the language server labels Jan 29, 2021
@alcarney alcarney mentioned this issue Jan 29, 2021
Merged
alcarney added a commit that referenced this issue Jan 29, 2021
@alcarney
Provide intersphinx completion suggestions (#76)
556aa29 
In the case where the intersphinx extension is enabled and configured. The language server will now offer completions for targets in intersphinx'd projects

Also fixed a bug where role target suggestions were being offered outside of a role

Closes #74 
Closes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lsp Issues that relate to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide intersphinx completion suggestions alcarney/esbonio
1 participant
@alcarney