Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect syntax highlighting for invalid literals #99

Closed
alcarney opened this issue Feb 5, 2021 · 0 comments · Fixed by #129
Closed

Incorrect syntax highlighting for invalid literals #99

alcarney opened this issue Feb 5, 2021 · 0 comments · Fixed by #129
Assignees
@alcarney
Labels
bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension

Comments

@alcarney
Copy link
Member

alcarney commented Feb 5, 2021

image

See the leading space? According to the documentation this is invalid markup and therefore should not be highlighted as a code literal.

I assume that the grammar has similar issues for italics and bold also
@alcarney alcarney added bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension labels Feb 5, 2021
@alcarney alcarney self-assigned this Feb 25, 2021
@alcarney alcarney mentioned this issue Feb 26, 2021
Merged
alcarney added a commit that referenced this issue Feb 26, 2021
@alcarney
Syntax highlighting fixes (#129)
2f18b73 
- Invalid literals are no longer highlighted as valid syntax Closes #99 
- Invalid bold text (e.g. `** invalid**`) is no longer highlighted as valid syntax. Closes #127 
- Invalid italic text (e.g. `*invalid *`) is no longer highlighted as valid syntax. Closes #128 
- Fix syntax highlighting for namespaced roles (e.g. `:py:func:`) and directives (e.g. `.. py:function::`) Closes #98 
- Adjust the scopes used by the grammar to hopefully be more consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alcarney alcarney

Labels
bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Syntax highlighting fixes alcarney/esbonio
1 participant
@alcarney