Some more fixes #954
Merged
Some more fixes #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow the preview to preserve its scroll state across refreshes
When registering new configuration subscriptions the server used to notify *all* subscriptions. This didn't make sense and led to a growing swell of log messages as configuration values were needlessly recomputed each time the list grew.
In the case where multiple components subscribe to the same set of configuration values, their callbacks are tracked together and notified at the same time. This should further reduce the amount of duplicate log noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#hashurl component if present before reloading the page. This should help preserve scroll state across reloads.Closes Investigate preview handling of anchor links #788
Closes Deduplicate configuration subscriptions #904