Add ObserveCenters post horizon find callback #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Apr 29, 2022
| * | ||
| * The columns of the dat file are: | ||
| * - %Time | ||
| * - GridCenter_X |
There was a problem hiding this comment.
Use lowercase xyz for consistency with the other observers.
|
@wthrowe could you please take another look at this when you get a chance? |
wthrowe
previously approved these changes
May 10, 2022
geoffrey4444
previously approved these changes
May 10, 2022
nilsdeppe
reviewed
May 10, 2022
| const std::string filename = "ObserveCentersTest_Output"; | ||
|
|
||
| // clean up just in case | ||
| if (file_system::check_if_file_exists(filename + ".h5")) { |
There was a problem hiding this comment.
in other places we mock the writing action to avoid doing file IO during tests. Can you please switch to that approach? File IO in tests is a bit annoying, especially on supercomputers with slow filesystems
|
Waiting for #3969 to be merged first to address @nilsdeppe's comment. |
|
@nilsdeppe @wthrowe @geoffrey4444 Now that #3969 is merged, I use that in the test rather than writing to disk. Also rebased on develop. |
wthrowe
approved these changes
May 18, 2022
nilsdeppe
approved these changes
May 18, 2022
geoffrey4444
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add post horizon find callback that writes the centers of apparent horizons (both in grid frame and inertial frame) to disk. Also add this callback to the BBH exec because this is useful info for binaries.
I don't believe this clashes with #3561 because the AHFinder library (wherever it winds up) will depend on ParallelInterpolation. This is just one more file that will have to be moved whenever the AHFinder library is moved.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments