-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CCE dependency from Interpolation #4299
Remove CCE dependency from Interpolation #4299
Conversation
maybe it would be more logical to move the callback into |
You're right, but that's true of any forward declaration and we use forward declarations in a lot of places. I guess it's just a preference on whether we want to keep all the interpolation callbacks in the same place or not. I don't see an obvious reason to require them to be in the same place. Furthermore, up until now, we haven't had any callbacks that truly depended on other libs. But in theory you could write a callback that does depend upon other libs. So in that case, you'd want to store it elsewhere. I think that's enough reason for me to move it to CCE. Does that sound good @nikwit? |
I think the reason we use forward declaration is mostly to reduce compilation time so we only include the symbols that we need rather than the entire header. Correct me if I'm wrong but the forward declaration here does not do much in terms of dependencies and I suspect just deleting the link dependency from CMake would also compile and link fine. I agree we should put it into |
5813b18
to
9336716
Compare
@nikwit ok it has been moved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I am not sure if we shouldn't also move it into the CCE namespace? Whaat do you think?
We could, but currently this isn't actually used anywhere except a test so not super important. I think I'll leave it as is for now |
Proposed changes
Addresses the CCE part of #3561.
Moves
SendGhWorldtubeData
to CCE.Upgrade instructions
src/ParallelAlgorithms/Interpolation/Callbacks/SendGhWorldtubeData.hpp
has been moved tosrc/Evolution/Systems/Cce/SendGhWorldtubeData.hpp
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments