Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Time from ParallelInterpolation #5275

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Aug 1, 2023

Proposed changes

Use some template magic.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose another option would be to require all "temporal IDs" can convert to double (with explicit operator double()). @wthrowe what do you think?

@wthrowe
Copy link
Member

wthrowe commented Aug 1, 2023

Interesting idea. I don't see anything obviously wrong with it. There's only one sane interpretation of a TimeStepId as a double, and there aren't many places where both types would be valid even if you did get confused about converting.

Go ahead if you want to try it. Shouldn't be too hard to back out if we find it causes a problem.

@kidder kidder merged commit b5f00e5 into sxs-collaboration:develop Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants