Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result is lost after going back to it #248

Closed
ndtoan96 opened this issue Oct 8, 2023 · 3 comments · Fixed by #249
Closed

Search result is lost after going back to it #248

ndtoan96 opened this issue Oct 8, 2023 · 3 comments · Fixed by #249

Comments

@ndtoan96
Copy link
Contributor

ndtoan96 commented Oct 8, 2023

Step to reproduce:

  1. Search something with s
  2. Use h to go to parent of a file
  3. Use H to go back to the search result -> It's empty

I haven't look into the search functionality yet, but I think we can either store the search result or perform the search again.

@sxyazi
Copy link
Owner

sxyazi commented Oct 8, 2023

I think that search results should not be added to the backstack since they are not actual directories but virtual ones.

When a user returns to the parent directory (or enters a subdirectory from the search results), it should be considered as abandoning those results, and the user should perform a new search when they need them.

@ndtoan96
Copy link
Contributor Author

ndtoan96 commented Oct 8, 2023

In that case, I think pressing H should returns to the path before the search. Because it feels weird to return to the search path without any result.

Copy link

github-actions bot commented Nov 8, 2023

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants