Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid adding non-regular paths to backstack #249

Merged
merged 2 commits into from
Oct 8, 2023
Merged

fix: avoid adding non-regular paths to backstack #249

merged 2 commits into from
Oct 8, 2023

Conversation

ndtoan96
Copy link
Contributor

@ndtoan96 ndtoan96 commented Oct 8, 2023

Fix #248

This PR remove search result from backstack.

@sxyazi
Copy link
Owner

sxyazi commented Oct 8, 2023

Thank you. use is_regular() is better than !is_search()

@sxyazi sxyazi merged commit f4a8b26 into sxyazi:main Oct 8, 2023
@sxyazi sxyazi changed the title avoid adding search to backstack fix: avoid adding non-regular paths to backstack Oct 8, 2023
@branchvincent branchvincent mentioned this pull request Oct 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search result is lost after going back to it
2 participants
@ndtoan96 @sxyazi