Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find #104

Merged
merged 6 commits into from
Sep 11, 2023
Merged

feat: find #104

merged 6 commits into from
Sep 11, 2023

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Sep 3, 2023

An implementation of the feature request: #81

Close #81


pr-104.mp4

@teto
Copy link

teto commented Sep 3, 2023

what software do you use to capture the video ? I like that but what would be even better is to update the selected item on each keypress way rather than waiting for the Enter keypress (similar to how ranger does)

@sxyazi
Copy link
Owner Author

sxyazi commented Sep 4, 2023

what software do you use to capture the video

https://github.com/wulkano/Kap for macOS

https://github.com/SeaDve/Kooha for Linux

I like that but what would be even better is to update the selected item

Do you mean the "filter" feature of ranger? It seems a duplicate of the existing "search".

@teto
Copy link

teto commented Sep 6, 2023

for people passing by, I answered here #81 (comment)

@sxyazi
Copy link
Owner Author

sxyazi commented Sep 10, 2023

Hey @teto, I believe I have implemented it in the way of Ranger, please give it a try.

The video has been updated to demonstrate it.

@teto
Copy link

teto commented Sep 10, 2023

Thanks I've just tested and that's exactly what I wanted <3 and I think it'sobjectively better than the initial behavior .

NB: Unrelated question but how could I map C-w to erase the last word. I tried doing so while testing the feature but was not sure how.

@sxyazi
Copy link
Owner Author

sxyazi commented Sep 11, 2023

NB: Unrelated question but how could I map C-w to erase the last word. I tried doing so while testing the feature but was not sure how.

C-w and these keybindings are included in the "Emacs readline keybindings for the Input component" feature, which has been documented in the Feature requests. I will find some time to implement it.

@sxyazi sxyazi merged commit 7ec7e36 into main Sep 11, 2023
@sxyazi sxyazi deleted the pr-4658255f branch September 11, 2023 10:49
@c02y
Copy link

c02y commented Sep 13, 2023

Sorry, I cannot activate the four find commands (find/find --previous/find_arrow/find_arrow --previous) using the builtin shortcuts like /.

yazi 0.1.4-1
Arch Linux

@sxyazi
Copy link
Owner Author

sxyazi commented Sep 19, 2023

@c02y This feature will be shipped with Yazi v0.1.5, you can build it from code to use it ahead

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request for "find" aka jump to matching file/folder
3 participants