Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ownership linemode #1238

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat: ownership linemode #1238

merged 4 commits into from
Jul 2, 2024

Conversation

AidanV
Copy link
Contributor

@AidanV AidanV commented Jun 30, 2024

Allowed uid and gid to be called on windows. When uid or gid is called on Windows it will return nil. This is similar to how "permissions" works.

This is a continuation of #932 I decided to not support ownership on Windows and instead have the same behaviour as permissions, which is to have the keybind do nothing.

Additionally added #[allow(unused_variables)] to permissions in order to suppress compiler warnings for unused variable "me" when compiling on Windows.

@sxyazi sxyazi force-pushed the ownership-linemode branch from c535be9 to a7722f5 Compare July 2, 2024 15:07
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sxyazi sxyazi merged commit 11547ee into sxyazi:main Jul 2, 2024
6 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants