Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nix)!: update dependencies #1456

Merged
merged 1 commit into from
Aug 10, 2024
Merged

refactor(nix)!: update dependencies #1456

merged 1 commit into from
Aug 10, 2024

Conversation

XYenon
Copy link
Contributor

@XYenon XYenon commented Aug 10, 2024

No description provided.

@sxyazi sxyazi changed the title nix: update dependencies chore(nix): update dependencies Aug 10, 2024
sxyazi
sxyazi approved these changes Aug 10, 2024
View reviewed changes
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks alot!

@sxyazi sxyazi merged commit 17c7003 into sxyazi:main Aug 10, 2024
6 checks passed
@uncenter
Copy link
Contributor

uncenter commented Aug 10, 2024 •
edited
Loading

This should probably be a refactor(nix)!: ... due to it both being breaking for users and changing the structure of the code. chore(nix): would be for things like updating the flake inputs. Not that it matters much and it's your repository but it makes it more difficult to follow changes to the Nix code here :)

@sxyazi sxyazi changed the title chore(nix): update dependencies refactor(nix)!: update dependencies Aug 10, 2024
@sxyazi
Copy link
Owner

sxyazi commented Aug 10, 2024

Thanks for the heads-up @uncenter, I've updated the title.

Sorry my poor nix-fu put it in the wrong category

@uncenter
Copy link
Contributor

Ahah no worries, thank you.

@Xerxes-2 Xerxes-2 mentioned this pull request Aug 15, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxyazi sxyazi sxyazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XYenon @uncenter @sxyazi