feat: new sort_sensitive option, and sort case-insensitively by default
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Which do you think is more common, case sensitive and case insensitive? i.e. is it necessary to set case insensitivity as the default? |
|
I can only speak for myself, but I prefer it to be case insensitive. And what default do you mean? The yazi.toml one, or the ones in the keymap? |
|
Yep, I agree with that as well. It seems that sorting by ASCII ordering doesn't make much sense, and case insensitivity makes more sense.
Both. |
Linus789
commented
Sep 14, 2023
Linus789
commented
Sep 14, 2023
|
Thank you, merged! |
sxyazi
changed the title
sort_sensitive option, and sort case-sensitively by default
sxyazi
changed the title
sort_sensitive option, and sort case-sensitively by defaultsort_sensitive option, and sort case-insensitively by default
sxyazi
pushed a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.