Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent Shift key behavior on Unix and Windows #174

Merged
merged 10 commits into from
Sep 20, 2023
Merged

fix: inconsistent Shift key behavior on Unix and Windows #174

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d5347fc
fix shift character keymap
ndtoan96 Sep 17, 2023
3ee8ef8
Merge branch 'main' of https://github.com/sxyazi/yazi into shift_char…
ndtoan96 Sep 17, 2023
95ffdd7
Format
sxyazi Sep 17, 2023
91ab4ea
Revert "fix shift character keymap"
ndtoan96 Sep 20, 2023
2376a56
fix keyevent inconsistency between Windows and Linux/Mac
ndtoan96 Sep 20, 2023
07d9a41
Merge branch 'shift_char_keymap' of https://github.com/ndtoan96/yazi …
ndtoan96 Sep 20, 2023
c735334
Update comment
sxyazi Sep 20, 2023
437ecc6
fix
sxyazi Sep 20, 2023
b9e9acc
fix again
sxyazi Sep 20, 2023
d1d84a2
merge same lines
sxyazi Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions config/src/keymap/key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,27 @@ impl Default for Key {

impl From<KeyEvent> for Key {
fn from(value: KeyEvent) -> Self {
let shift = matches!(value.code, KeyCode::Char(c) if c.is_ascii_uppercase());
sxyazi marked this conversation as resolved.
Show resolved Hide resolved
// For alphabet:
// Unix : <S-a> => Char("A") + SHIFT
// Windows : <S-a> => Char("A") + SHIFT
//
// For non-alphabet:
// Unix : <S-`> => Char("~") + NULL
// Windows : <S-`> => Char("~") + SHIFT
//
// So we detect `Char("~") + SHIFT`, and change it to `Char("~") + NULL`
// for consistent behavior between OSs.

let shift = match (value.code, value.modifiers) {
(KeyCode::Char(c), _) => c.is_ascii_uppercase(),
(_, m) => m.contains(KeyModifiers::SHIFT),
};

Self {
code: value.code,
shift: shift || value.modifiers.contains(KeyModifiers::SHIFT),
ctrl: value.modifiers.contains(KeyModifiers::CONTROL),
alt: value.modifiers.contains(KeyModifiers::ALT),
code: value.code,
shift,
ctrl: value.modifiers.contains(KeyModifiers::CONTROL),
alt: value.modifiers.contains(KeyModifiers::ALT),
}
}
}
Expand Down