feat: append the suffix to the end when generating unique filenames for directories, i.e., after not before the extension #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or directories, i.e., after not before the extension
sxyazi
force-pushed
the
rename-folder-index
branch
from
96def54 to
92ff55f
Compare
sxyazi
changed the title
|
@sxyazi Thank you for merging my pull request. I really appreciate it. If possible, could you please add the 'hacktoberfest-accepted' label to this PR? Thanks again. |
|
Done! @Saru2003 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the folder renaming functionality in the unique_name function. The change ensures that when renaming a folder with a duplicate name, the index is appended at the end of the folder name (e.g., changing a.b.c to a.b.c_1), rather than before the last dot.
This is addressed towards issue #1774, enhancing the usability of the renaming feature by preventing confusion with file names.
Closes: #1774
Please review my implementation and provide feedback.