Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a logic error in Step #233

Merged
merged 2 commits into from
Oct 1, 2023
Merged

fix: a logic error in Step #233

merged 2 commits into from
Oct 1, 2023

Conversation

ndtoan96
Copy link
Contributor

fix #231

@sxyazi
Copy link
Owner

sxyazi commented Oct 1, 2023

Thank you for the PR.

But I can't reproduce the issue, and not quite clear on why "prev" would result in old < self.cursor, any tips here?

1.mp4

@ndtoan96
Copy link
Contributor Author

ndtoan96 commented Oct 1, 2023

Supposed you have two subfolders in the current folder

-->a
   b

You put the cursor at the second one (but don't enter it)

   a
-->b

Then cd to the first one.

Only debug build will get this issue, because --release build wraps around overflow by default.

@sxyazi
Copy link
Owner

sxyazi commented Oct 1, 2023

I reproduced it.

Thanks for the report, it was a logic error of Step introduced by #213, not an overflow error.

@sxyazi sxyazi changed the title fix: usize overflow fix: a logic error in Step Oct 1, 2023
@sxyazi sxyazi merged commit 31f4058 into sxyazi:main Oct 1, 2023
sxyazi pushed a commit that referenced this pull request Oct 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: cd exit with code 101
2 participants