perf: reimplement optimized natural sorting algorithm, speed up ~6 times for case-insensitive sorting #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes the performance regression caused by the introduction of case-insensitive sorting.
Quote from Discord:
Benchmark
Sorting 100,000 files with case-insensitive sorting, speeds up by 6 times:
Since Yazi didn't introduce any benchmark framework, I used
Instant
for a rough measurement, which is simple enough. There is benchmark code innatsort.rs
as well; you can run it yourself.