Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build universal wheels #154

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Don't build universal wheels #154

merged 1 commit into from
Jun 15, 2020

Conversation

wyattanderson
Copy link

(Universal wheels)[https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels] are wheels that are compatible with both Python 2 and Python 3; python-rsa is no longer Python 2 compatible as of 4.6.

The wheels pushed for 4.6 in #152 have invalid names, falsely advertising them as universal wheels, which can cause problems in some legacy build systems.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.25% when pulling 05b2619 on wyattanderson:not-universal into a87a564 on sybrenstuvel:master.

@sybrenstuvel
Copy link
Owner

The less configuration needed, the better. Thanks for the PR.

@sybrenstuvel sybrenstuvel merged commit e8fc5d2 into sybrenstuvel:master Jun 15, 2020
@wyattanderson wyattanderson deleted the not-universal branch June 15, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants