Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic Docker image build #43

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Add automatic Docker image build #43

merged 7 commits into from
Jul 3, 2024

Conversation

vlnst
Copy link
Contributor

@vlnst vlnst commented Jun 8, 2024

I think it would be convenient to have latest images build automatically (so people don't have to build them on their servers), except I think I also should add dev version of a container since releases are quite rare.

This code allows for automatic image build on release.

@syeopite syeopite self-requested a review June 8, 2024 22:08
Copy link
Owner

@syeopite syeopite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'll prefer it if Priviblur can be published on Quay though similar to how other Privacy frontend projects are.

And yes a tag for the latest unstable commit from the master branch would be great to have

@vlnst vlnst marked this pull request as ready for review June 12, 2024 13:32
.github/workflows/release-docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@TheFrenchGhosty TheFrenchGhosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an "expert" of GitHub CI, but this PR seems okay to me, even if it's far from perfect:

  • ARM isn't supported for example
  • Images never expires
  • ...

I never personally made images with releases so I don't really know if the way you did it is correct, but it should be fine.

The rest seems OK

.github/workflows/docker.yml Outdated Show resolved Hide resolved
@syeopite
Copy link
Owner

syeopite commented Jun 14, 2024

Following a discussion I had with @TheFrenchGhosty, I'm only going to be officially supporting the release-image.

The "official" unstable image that builds off master would instead be pussthecat.org's image here https://github.com/PussTheCat-org/docker-priviblur-quay

Please remove the CI for the unstable-image, and address the issues @TheFrenchGhosty mentioned for the release-image.

My apologies about the extra work. Also, you do not have to force-push the branch each time you make any changes. GitHub's UI allows me to squish the commits when merging.

@vlnst
Copy link
Contributor Author

vlnst commented Jun 14, 2024

I'm not an "expert" of GitHub CI

I'm not an expert in this either, I waited for someone to make an automatic build but no one has taken on it for a while.
I will try to implement what you wrote and once again carefully check everything to see what and how can be improved.

I never personally made images with releases so I don't really know if the way you did it is correct, but it should be fine.

I don't have an account on quay.io so I can't test if its correct

Please remove the CI for the unstable-image, and address the issues @TheFrenchGhosty mentioned for the release-image.

Okay

My apologies about the extra work.

Don't worry about it!

Also, you do not have to force-push the branch each time you make any changes. GitHub's UI allows me to squish the commits when merging.

Forgot that feature exists :D

@TheFrenchGhosty I've asked you a few questions about Dockerfile on XMPP. Your response would be greatly appreciated.

@vlnst
Copy link
Contributor Author

vlnst commented Jun 24, 2024

I'm not sure if its preferable to build different images for different architectures as it is done in here or just one image with support for multiple.

syeopite added 7 commits July 2, 2024 22:25
Remove automatic build on every commit, add support for arm architectures, add image expiration

Fix variable

Co-authored-by: Ftonans <private>
Release images should not be expirable
docker/metadata-action requires a push tag event for
semvar tag to work correctly
@syeopite syeopite merged commit ac5ebe4 into syeopite:master Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants