-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic Docker image build #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'll prefer it if Priviblur can be published on Quay though similar to how other Privacy frontend projects are.
And yes a tag for the latest unstable commit from the master branch would be great to have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an "expert" of GitHub CI, but this PR seems okay to me, even if it's far from perfect:
- ARM isn't supported for example
- Images never expires
- ...
I never personally made images with releases so I don't really know if the way you did it is correct, but it should be fine.
The rest seems OK
Following a discussion I had with @TheFrenchGhosty, I'm only going to be officially supporting the release-image. The "official" unstable image that builds off master would instead be pussthecat.org's image here https://github.com/PussTheCat-org/docker-priviblur-quay Please remove the CI for the unstable-image, and address the issues @TheFrenchGhosty mentioned for the release-image. My apologies about the extra work. Also, you do not have to force-push the branch each time you make any changes. GitHub's UI allows me to squish the commits when merging. |
I'm not an expert in this either, I waited for someone to make an automatic build but no one has taken on it for a while.
I don't have an account on quay.io so I can't test if its correct
Okay
Don't worry about it!
Forgot that feature exists :D @TheFrenchGhosty I've asked you a few questions about Dockerfile on XMPP. Your response would be greatly appreciated. |
I'm not sure if its preferable to build different images for different architectures as it is done in here or just one image with support for multiple. |
Remove automatic build on every commit, add support for arm architectures, add image expiration Fix variable Co-authored-by: Ftonans <private>
Release images should not be expirable
docker/metadata-action requires a push tag event for semvar tag to work correctly
I think it would be convenient to have latest images build automatically (so people don't have to build them on their servers), except I think I also should add dev version of a container since releases are quite rare.
This code allows for automatic image build on release.