feat: custom metadata support #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OptMetadata, which allows supplying custom metadata when calling NewDescriptorInput. Add GetMetadata, which allows a user to parse custom metadata from a Descriptor.
tri-adam
force-pushed
the
get-set-metadata
branch
from
81ad1d3 to
59a5446
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 72.64% 72.72% +0.08%
==========================================
Files 35 35
Lines 2884 2904 +20
==========================================
+ Hits 2095 2112 +17
- Misses 636 638 +2
- Partials 153 154 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Switch to encoding.BinaryUnmarshaler/encoding.BinaryMarshaler for GetMetadata/OptMetadata rather than "any" type.
tri-adam
force-pushed
the
get-set-metadata
branch
from
0477369 to
6e2497e
Compare
EmmEff
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
OptMetadata, which allows supplying custom metadata when callingNewDescriptorInput. AddGetMetadata, which allows a user to parse custom metadata from aDescriptor.Note that I've had to disable the
unusedlinter, since the code in this PR triggers a panic in the linter. I've opened #269 to re-enable that in the future, once the bug is fixed.