move OCI/Docker-registry-related cmds from remote to their own cmd
#1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preminger
force-pushed
the
1894-move-oci-registry-operations-from-remote-to-new-registry-command
branch
2 times, most recently
from
d72dfc8 to
a8d8fb8
Compare
preminger
changed the title
remote to their own cmdremote to their own cmd
dtrudg
reviewed
Jul 21, 2023
preminger
force-pushed
the
1894-move-oci-registry-operations-from-remote-to-new-registry-command
branch
2 times, most recently
from
d0c4010 to
9c43892
Compare
preminger
force-pushed
the
1894-move-oci-registry-operations-from-remote-to-new-registry-command
branch
2 times, most recently
from
b4c409d to
228f623
Compare
added 9 commits
July 21, 2023 11:28
preminger
force-pushed
the
1894-move-oci-registry-operations-from-remote-to-new-registry-command
branch
from
228f623 to
eee3372
Compare
dtrudg
approved these changes
Jul 21, 2023
This was referenced Jul 28, 2023
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Moves the operations associated with OCI/Docker registries -
login,logout, andlist- from subcommands of theremotecommand (singularity remote login [options] <registryURI>, etc.) to their own dedicated command,registry(singularity registry login [options] <registryURI>, etc.). See the output ofsingularity help registryfor more information.Note that this does not remove the subcommands
login,logout, andlistfromsingularity remote, as they have separate functionality when given a remote endpoint (Singularity Cloud Services, Singularity Enterprise installs) as an argument. This former "duality" of functions ofsingularity remote {login, logout, list}is in fact a central part of the motivation for this PR. (See #1639 for discussion.) See the output ofsingularity help remotefor more information.This fixes or addresses the following GitHub issues:
remoteto newregistrycommand #1894