Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update LICENSE_DEPENDENCIES.md generation (release-4.0) #2160

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Sep 5, 2023

Description of the Pull Request (PR):

Upgrade go-licenses to the latest 1.6.0 which now handles the UNLICENSE properly, etc.

Use a template approach for the markdown generation, rather than converting from CSV ourselves.

The template includes full license text, per-dependency, rather than a link to the URL for the dependency's license. This is useful as it:

  • Ensures we are distributing the required license.
  • Avoids versioned links that change at each dependency update, and require manual resolution for dependabot updates.

Write your description of the PR here. Be sure to include as much background,
and details necessary for the reviewers to understand exactly what this is
fixing or enhancing.

@dtrudg dtrudg self-assigned this Sep 5, 2023
@dtrudg dtrudg changed the title Bump go licenses 4.0 (release-4.0) doc: Update LICENSE_DEPENDENCIES.md generation (release-4.0) Sep 5, 2023
@dtrudg dtrudg force-pushed the bump-go-licenses-4.0 branch from b872445 to 3874097 Compare September 5, 2023 09:32
Upgrade go-licenses to the latest 1.6.0 which now handles the
UNLICENSE properly, etc.

Use a template approach for the markdown generation, rather than
converting from CSV ourselves.

The template includes full license text, per-dependency, rather than a
link to the URL for the dependency's license. This is useful as it:

* Ensures we are distributing the required license.
* Avoids versioned links that change at each dependency update, and
  require manual resolution for dependabot updates.
@dtrudg dtrudg force-pushed the bump-go-licenses-4.0 branch from 3874097 to 3ee551d Compare September 5, 2023 09:33
@dtrudg dtrudg marked this pull request as ready for review September 5, 2023 09:49
@dtrudg dtrudg assigned preminger and unassigned preminger Sep 5, 2023
@dtrudg dtrudg requested a review from preminger September 5, 2023 09:49
@dtrudg dtrudg merged commit 94f30d9 into sylabs:release-4.0 Sep 5, 2023
@dtrudg dtrudg deleted the bump-go-licenses-4.0 branch September 5, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants