Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved readability of text above featured images #247

Merged
merged 4 commits into from
Feb 20, 2021

Conversation

danisztls
Copy link
Contributor

I changed the shadow size to be relative to the font size and applie it also to the subtitle (post-info class). Also did a number of small related changes.

@sylhare
Copy link
Owner

sylhare commented Feb 18, 2021

Thanks! You are giving me a lot of things to review ahah 😄

@sylhare sylhare self-requested a review February 18, 2021 15:33
Copy link
Owner

@sylhare sylhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice on the feature image post.
The only downside is when there's no feature image, the shadow seems a bit too strong:

before
image

Now
image

I suppose the new shadow could be under .feature-img h1.title and the h1.title could keep the previous shadow. Something like that 🤔

@danisztls
Copy link
Contributor Author

Done.

I also did a selector simplification that I'm not 100% sure is ok.

@sylhare
Copy link
Owner

sylhare commented Feb 20, 2021

Thanks, yeah the scss was a good idea but a bit dodgy, it was rendering extra stuff with shadow, so I updated it and now it's all good 😉

@sylhare sylhare merged commit 67a9552 into sylhare:master Feb 20, 2021
@danisztls danisztls deleted the readability branch February 20, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants