Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Mermaid and Simple-jekyll-search to latest version #254

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

danisztls
Copy link
Contributor

They are working on my initial gulp branch and should be working here too.

@sylhare
Copy link
Owner

sylhare commented Mar 5, 2021

Seems like the search function does not work anymore with this update:

ReferenceError: SimpleJekyllSearch is not defined

Maybe the API has changed.

And I get a strange warning with mermaid (which was not present before):

Source map error: Error: request failed with status 404
Resource URL: http://127.0.0.1:4000/Type-on-Strap/assets/js/vendor/mermaid.min.js
Source Map URL: mermaid.min.js.map

@danisztls
Copy link
Contributor Author

I will look at it. That strange error is the map file that I deleted but left somehow a reference to it. The search is working in the first branch so I must have missed something.

@danisztls
Copy link
Contributor Author

Fixed both.

Copy link
Owner

@sylhare sylhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to keep the .map for mermaid as we don't need to debug it.
I tried using the v8.9.1 directly from the release source and the warning is not showing up anymore.

Did you use the release dist folder?

@danisztls
Copy link
Contributor Author

Yep. Just added this:
/* @license Mermaid 8.9.1 MIT License */

And I get the error after removing the .map.

@danisztls
Copy link
Contributor Author

Which is solved by removing the reference to it on mermaid.min.js.

@sylhare sylhare self-requested a review March 22, 2021 20:00
@sylhare sylhare merged commit b3643fc into sylhare:master Mar 22, 2021
@sylhare sylhare mentioned this pull request Mar 22, 2021
@danisztls danisztls deleted the vendor-update branch March 23, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants