-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Mermaid and Simple-jekyll-search to latest version #254
Conversation
Seems like the search function does not work anymore with this update:
Maybe the API has changed. And I get a strange warning with mermaid (which was not present before):
|
I will look at it. That strange error is the map file that I deleted but left somehow a reference to it. The search is working in the first branch so I must have missed something. |
Fixed both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to keep the .map
for mermaid as we don't need to debug it.
I tried using the v8.9.1 directly from the release source and the warning is not showing up anymore.
Did you use the release dist folder?
Yep. Just added this: And I get the error after removing the |
Which is solved by removing the reference to it on |
They are working on my initial gulp branch and should be working here too.