Implement comments with Cusdis #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was using the wrong base16 color.
- Update grey shades from Github dark dimmed - Create 3 new base colors to use as base for theme (non-HL) colors - Move colors to start of file to avoid an undeclared variable error
- Light (original) theme is on by default - Dark theme can be enabled by uncommenting its section - Color scheme have 10 shades and 8 colors which can be used to ajust theme colors globally - base16 highlighting theme use colors from above scheme
- Set fa-inverse to background color. - Load Sass variables before external. That could lead to bugs. (cherry picked from commit 6131c83d6d85019c61fe6976e9c85722940fc09e)
- Swap light/dark via prefs-color-scheme. - Dark scheme is good but light needs ajustments. - Highlight uses the same base16 scheme for light/dark
Needed for color scheme switching as SaaS variables are compiled.
- Update color scheme. - Do small CSS adjustments.
Added a slightly transparent background to div element and a bit of margin for the child svg element.
9 tasks
djyde
reviewed
Apr 21, 2021
_includes/cusdis.html
Outdated
| @@ -0,0 +1,8 @@ | |||
| <div class="comments" id="cusdis" | |||
| data-host="https://cusdis.com" | |||
| data-app-id={{site.cusdis_id}} | |||
There was a problem hiding this comment.
Yep. Among other stuff. Tested and fixed it in my last commit.
It also works with localhost. May be a good idea to restrict domain in the future to avoid spam/dos.
|
That's cool! I am looking forward to test it 👍 |
- Remove copyleft notice from script as code is fully rewritten - I don't know if browsers got smarter but some things the script did aren't needed, at least on recent Chromium
The options are 'auto', 'dark' and 'light'.
…cusdis # Conflicts: # _config.yml
|
Yeah the rebase went wrong, sorry I messed up the branch |
|
How about adding i18n support? @lbcnz https://cusdis.com/doc#/advanced/i18n |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suport to Cusdis, an alternative to Disqus.