Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K4] 4.0 Compatibility #20

Closed
afbora opened this issue Nov 28, 2023 · 2 comments
Closed

[K4] 4.0 Compatibility #20

afbora opened this issue Nov 28, 2023 · 2 comments

Comments

@afbora
Copy link

afbora commented Nov 28, 2023

Minor UI issue for K4

screen-capture-1764-Test - Mægazine-plugins test

Kirby 4.0.0-rc.4
PHP 8.1.23
@afbora afbora mentioned this issue Nov 28, 2023
Closed
@mrflix
Copy link

mrflix commented Dec 7, 2023

The UI breaks because the main selector for all the styling doesn't match any longer:

.k-input[data-theme="field"][data-type="embed"]

I successfully replaced it with the following selector:

.k-embed-field

sylvainjule added a commit that referenced this issue Mar 6, 2024
@sylvainjule
Update styling (K4 compatibility). #20
5ae0434
sylvainjule added a commit that referenced this issue Mar 6, 2024
@sylvainjule
Rename isValidUrl method, now used as computed value in native field …
6607d8a 
…(K4 compatibility). #20
@sylvainjule
Copy link
Owner

✓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrflix @afbora @sylvainjule