Add flash messages #158
Closed
Add flash messages #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
voronkovich
commented
Aug 29, 2015
voronkovich
commented
| @@ -195,6 +195,18 @@ | |||
| <source>post.no_comments</source> | |||
| <target>Будьте первыми кто прокомментирует эту запись.</target> | |||
| </trans-unit> | |||
| <trans-unit id="post.created_successfully"> | |||
| <source>post.created_successfully</source> | |||
| <target>Запись успешно сохранена!</target> | |||
There was a problem hiding this comment.
I think better is создана instead of сохранена in this case to be consistent with English translation and translation key.
There was a problem hiding this comment.
You're right, @bocharsky-bw. I've fixed the translation.
bocharsky-bw
added a commit
to bocharsky-bw/demo
that referenced
this pull request
Aug 30, 2015
In addition to symfony#158
voronkovich
force-pushed
the
add-flash-messages
branch
from
2515746 to
4f95a5b
Compare
|
👍 |
voronkovich
force-pushed
the
add-flash-messages
branch
from
4f95a5b to
48900fa
Compare
Merged
|
@voronkovich thanks for working on this. Even if I don't like to display flash messages for when things go right ... I like this PR because it shows a complete example of how to display flash messages, and that's definitely something we want to do. My only concern was that the original code was a bit overcomplicated for the demo application. That's why I took your work and made some simplifications in #163. I'm closing this PR then, but I reused your commits, so you'll get full credit for your work. Thanks! |
| @@ -7,6 +7,9 @@ | |||
| #} | |||
| {% extends 'base.html.twig' %} | |||
|
|
|||
| {# Import macros needed for displaying flash messages. See http://twig.sensiolabs.org/doc/tags/import.html #} | |||
| {% import 'macro/messages.html.twig' as messages %} | |||
There was a problem hiding this comment.
macros should be imported in the template where they are used. Importing them in a parent template and expecting them to work in child templates is just a side effect of the Twig 1.x implementation, and does not work anymore in Twig 2
bocharsky-bw
added a commit
to bocharsky-bw/demo
that referenced
this pull request
Sep 1, 2015
In addition to symfony#158
javiereguiluz
added a commit
that referenced
this pull request
Sep 7, 2015
This PR was merged into the master branch. Discussion ---------- Add flash messages This finishes #158 by simplifying its contents. Commits ------- 3eefa76 Reworded the help note about flash messages 9a8d43d Check if the session exists before reading flash messages d01311b Transformed the macro() of the Flash messages into a regular include() template f481eef Refactored the template code related to macros da04216 Fixed an issue with the translation file after the rebase 51f7262 Restored the content database 7507a50 Simplified the template code used to render flash messages a46c948 Use 'success' as the name of the messages related to success messages 12bd670 Update Russian and English translations 0680841 Show flash messages after creating, updating and deleting posts
javiereguiluz
added a commit
that referenced
this pull request
Sep 7, 2015
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
In addition to symfony/demo#158
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Update uk translations for flash messages In addition to symfony/demo#158 Commits ------- 87fc8e0 Update uk translations for flash messages
mwhorse46
added a commit
to mwhorse46/sym_proj
that referenced
this pull request
Apr 16, 2023
In addition to symfony/demo#158
mwhorse46
added a commit
to mwhorse46/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Update uk translations for flash messages In addition to symfony/demo#158 Commits ------- 87fc8e0 Update uk translations for flash messages
muqeetsyed
pushed a commit
to muqeetsyed/symfony-webencore
that referenced
this pull request
Dec 26, 2024
In addition to symfony/demo#158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.