Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translations for flash messages #178

Closed
wants to merge 2 commits into from
Closed

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 7, 2015

This adds German translations for the flash messages added in #163.

This adds German translations for the flash messages added in symfony#163.
</trans-unit>
<trans-unit id="post.deleted_successfully">
<source>post.deleted_successfully</source>
<target>Beitrag gelöscht!</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak German so I don't pretend to correct you, but if the original English message is Post deleted successfully!, shouldn't the translation be something like Der Beitrag wurde erfolgreich gelöscht. instead of Beitrag gelöscht?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that (both forms are correct). Though in the English version we don't use complete sentences too.

@OskarStark What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should use the long version from @javiereguiluz

Der Beitrag wurde erfolgreich gelöscht!

same for the both above

Der Beitrag wurde erfolgreich bearbeitet!
Der Beitrag wurde erfolgreich erstellt!

@xabbuh
Copy link
Member Author

xabbuh commented Sep 8, 2015

I update here.

@javiereguiluz
Copy link
Member

@xabbuh thanks a lot for this contribution and for your patience! Danke sehr

@xabbuh xabbuh deleted the patch-1 branch September 8, 2015 20:08
@xabbuh
Copy link
Member Author

xabbuh commented Sep 8, 2015

Gern geschehen. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants