[DomCrawler] Make ChoiceFormField::isDisabled return true for unc…

…hecked disabled checkboxes
symfony · Jan 9, 2025 · fd07959 · fd07959
1 parent 4304e6a
commit fd07959
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Field/ChoiceFormField.php b/Field/ChoiceFormField.php
@@ -45,6 +45,10 @@ public function hasValue(): bool
      */
     public function isDisabled(): bool
     {
+        if ('checkbox' === $this->type) {
+            return parent::isDisabled();
+        }
+
         if (parent::isDisabled() && 'select' === $this->type) {
             return true;
         }

diff --git a/Tests/Field/ChoiceFormFieldTest.php b/Tests/Field/ChoiceFormFieldTest.php
@@ -272,6 +272,17 @@ public function testCheckboxWithEmptyBooleanAttribute()
         $this->assertEquals('foo', $field->getValue());
     }
 
+    public function testCheckboxIsDisabled()
+    {
+        $node = $this->createNode('input', '', ['type' => 'checkbox', 'name' => 'name', 'disabled' => '']);
+        $field = new ChoiceFormField($node);
+
+        $this->assertTrue($field->isDisabled(), '->isDisabled() returns true when the checkbox is disabled, even if it is not checked');
+
+        $field->tick();
+        $this->assertTrue($field->isDisabled(), '->isDisabled() returns true when the checkbox is disabled, even if it is checked');
+    }
+
     public function testTick()
     {
         $node = $this->createSelectNode(['foo' => false, 'bar' => false]);