Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:controller] replace repository method add by save #1226

Merged
merged 1 commit into from
Nov 8, 2022
Merged

[make:controller] replace repository method add by save #1226

merged 1 commit into from
Nov 8, 2022

Conversation

bechir
Copy link
Contributor

@bechir bechir commented Oct 21, 2022

The generated repository class by make:entity doesn’t have method add actually.
So I replaced the method add by save in crud/tests/Test.*.tpl.php

@jrushlow jrushlow added the Bug Bug Fix label Nov 8, 2022
jrushlow
jrushlow approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bechir for the fix!

@jrushlow jrushlow changed the title fix(make:controller): replace repository method add by save [make:controller] replace repository method add by save Nov 8, 2022
@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label Nov 8, 2022
@jrushlow jrushlow merged commit a6423e3 into symfony:main Nov 8, 2022
@bechir bechir deleted the fix/controller-test branch November 8, 2022 16:37
@jrushlow jrushlow mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bechir @jrushlow