[make:entity] managing keyword prefixes (is, has) for boolean properties getters #1493
Conversation
There was a problem hiding this comment.
This change makes sense to me. It's consistent with the autodetection of the type (boolean) when asking for the type.
I'd suggest doing the same for setters, but only for the "is" prefix: isInternational property => setInternational. (but hasColor => setHasColor)
There was a problem hiding this comment.
This looks pretty good @ClemRiviere! - 1 minor comment. Also if you're up for doing the same for addSetter() as @nicolas-grekas suggested, that would be even more awesome!
jrushlow
added
Status: Reviewed
|
This change does not make sense to me as it makes those setter incompatible with the property-access component (and so with the form component that relies on it) |
|
A link wasn't added automatically (maybe becaues it was a discussion, not an issue), but this is now causing property access issues as discussed in symfony/symfony#54885 (reply in thread). |
|
@stof I understand, I think we have two potential solutions for this :
I would personally go for the first solution, @jrushlow or @nicolas-grekas do you guys have any advices on this topic ? |
… setters (octoseth)
This PR was merged into the 1.x-dev branch.
Discussion
----------
[make-entity]Keep the 'is' prefixes for booleans properties setters
When generating a new entity, if we name a boolean property with the prefix "is", this prefix is removed to construct the setter.
example:
```
bool $isInternational;
public function isInternational(): ?bool
{
return $this->isInternational;
}
public function setInternational(bool $isInternational): static
{
$this->isInternational = $isInternational;
return $this;
}
```
This is breaking when we want to access the property via a form :
> [NoSuchPropertyException]
> HTTP 500 Internal Server Error
> The method "isInternational" in class "App\Entity\Conference" requires 0 arguments, but should accept only 1.. Make the property public, add a setter, or set the "mapped" field option in the form type to be false.
This PR revert this change introduce in [PR 1493](#1493) to keep the 'is' prefix on the setter.
example :
```
public function setIsInternational(bool $isInternational): static
{
$this->isInternational = $isInternational;
return $this;
}
```
Commits
-------
9fa9221 Keep the 'is' prefix on a boolean property when making the setter
make:entityRelated to #1492