Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:auth] only fire deprecation when command is called #1532

Merged
merged 2 commits into from
May 3, 2024
Merged

[make:auth] only fire deprecation when command is called #1532

merged 2 commits into from
May 3, 2024

Conversation

eltharin
Copy link
Contributor

@eltharin eltharin commented May 3, 2024

fixes #1530

@jrushlow jrushlow added Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer labels May 3, 2024
@jrushlow jrushlow changed the title change trigger_deprecation location [make:auth] only fire deprecation when command is called May 3, 2024
jrushlow
jrushlow approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eltharin!

@jrushlow jrushlow merged commit 132d766 into symfony:main May 3, 2024
7 checks passed
@jrushlow jrushlow mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[make:auth] V1.59 - Deprecated classes causes deprecated message on each page
2 participants
@eltharin @jrushlow