Preserve existing class metadata #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ro0NL! We load the disconnected metadata factory when/because we can’t use the normal metadata factory, usually (entirely?) when we’re readijg metadata for an entity whose class doesn’t yet exist (so the normal metadata factory throws an error). Won’t using the metadata factory here trigger that error? It looks like the tests may be failing due to this. |
|
after submitting the PR i realized a call to The current approach (try/catching) works for me. |
|
Very interesting - nice work. Thank you @ro0NL! |
weaverryan
added a commit
that referenced
this pull request
Jun 13, 2018
This PR was squashed before being merged into the 1.0-dev branch (closes #197). Discussion ---------- Preserve existing class metadata Hi, Im facing an issue related to `make:entity`. I noticed it uses `DisconnectedClassMetadataFactory` which at this point basically forgets about existing metadata (metadata that on itself is loaded during the `loadClassMetadata` event). Real life example is e.g. https://github.com/msgphp/symfony-demo-app/blob/b9536243f4a0803b36acfef839ac0c3559a91bd6/src/Entity/User/UserRole.php#L11 where the `roles` field is mapped during `loadClassMetadata`. Currently its mapping is not loaded, causing an invalid field override here. This solves it. Commits ------- 79ba86a Preserve existing class metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Im facing an issue related to
make:entity. I noticed it usesDisconnectedClassMetadataFactorywhich at this point basically forgets about existing metadata (metadata that on itself is loaded during theloadClassMetadataevent).Real life example is e.g. https://github.com/msgphp/symfony-demo-app/blob/b9536243f4a0803b36acfef839ac0c3559a91bd6/src/Entity/User/UserRole.php#L11 where the
rolesfield is mapped duringloadClassMetadata.Currently its mapping is not loaded, causing an invalid field override here.
This solves it.