Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make:entity: Add return type to getId() #215

Merged
merged 1 commit into from
Jul 5, 2018
Merged

make:entity: Add return type to getId() #215

merged 1 commit into from
Jul 5, 2018

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jun 21, 2018

No description provided.

localheinz
localheinz approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lyrixx
Copy link
Member

lyrixx commented Jun 21, 2018

What if id are uuid ?

@gharlan
Copy link
Contributor Author

gharlan commented Jun 21, 2018

What if id are uuid ?

Then the doctrine type for $id is already wrong, right? (line 19)
So imo it is consistent to use int type hint here.

@javiereguiluz
Copy link
Member

Thank you Gregor.

@javiereguiluz javiereguiluz merged commit a7da2c6 into symfony:master Jul 5, 2018
javiereguiluz added a commit that referenced this pull request Jul 5, 2018
@javiereguiluz
minor #215 make:entity: Add return type to getId() (gharlan)
432caaa 
This PR was merged into the 1.0-dev branch.

Discussion
----------

make:entity: Add return type to getId()

Commits
-------

a7da2c6 make:entity: Add return type to getId()
@gharlan gharlan deleted the patch-1 branch July 5, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@localheinz localheinz localheinz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gharlan @lyrixx @javiereguiluz @localheinz