Extend from AbstractController and use Symfony's @Route #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royklutman
changed the title
|
Thanks Roy! It looks like you did a very good job! We have some great tests to make sure the functionality of the generated code actually works - so we don't need to worry. Thanks for noticing and fixing this! |
weaverryan
added a commit
that referenced
this pull request
Aug 29, 2018
…klutman) This PR was merged into the 1.0-dev branch. Discussion ---------- Extend from AbstractController and use Symfony's @route This PR would close #240 and update the `make:crud` command to correctly use Symfony's Routing component instead of the deprecated `FrameworkExtraBundle`'s. Would appreciate a thorough review as all I did was basically look at @javiereguiluz's PR #221 for the AbstractController fix. Commits ------- 07166c9 Extend from AbstractController and use Symfony's Route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would close #240 and update the
make:crudcommand to correctly use Symfony's Routing component instead of the deprecatedFrameworkExtraBundle's. Would appreciate a thorough review as all I did was basically look at @javiereguiluz's PR #221 for the AbstractController fix.