Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate elasticsearch type, and split it into elastica and elastic_search types #438

Merged
merged 2 commits into from
May 10, 2022

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented May 10, 2022

Fixes #424

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests for this change?

DependencyInjection/MonologExtension.php Outdated Show resolved Hide resolved
Co-authored-by: Alexander M. Turek <[email protected]>
@Seldaek Seldaek merged commit f5b44f1 into symfony:master May 10, 2022
@Seldaek Seldaek deleted the elastic_cleanup branch May 10, 2022 14:13
Seldaek added a commit that referenced this pull request May 10, 2022
@Seldaek
Copy link
Member Author

Seldaek commented May 10, 2022

See 769b7da for a last fix here, forgot to add the factory

@korolev-d-l
Copy link

korolev-d-l commented May 10, 2023

elastic_search.host does not work, must be array
https://github.com/elastic/elasticsearch-php/blob/main/docs/config-hash.asciidoc

https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/MonologExtension.php#L292
need array for elastic_search, and key "hosts", example:
$clientArguments = [ 'hosts' => $handler['elasticsearch']['host'], ];
OR
$clientArguments = [ 'hosts' => $handler['elasticsearch']['hosts'], ];
And fix Configuration, host must be array|string:
https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Configuration.php#L98
https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Configuration.php#L879


See fix, but I haven't tested it yet
923b1b9

@JulienMarliac
Copy link

Hey

I can confirm that elastic_search does not work (see @Chameleon-m message) , any plans on the fix ? Or should I open a new issue ?

@Kenneth-Sills
Copy link

Ticket created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collision between ElasticSearchHandler and ElasticaHandler
6 participants