-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate elasticsearch type, and split it into elastica and elastic_search types #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add tests for this change?
Co-authored-by: Alexander M. Turek <[email protected]>
See 769b7da for a last fix here, forgot to add the factory |
elastic_search.host does not work, must be array https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/MonologExtension.php#L292 See fix, but I haven't tested it yet |
Hey I can confirm that elastic_search does not work (see @Chameleon-m message) , any plans on the fix ? Or should I open a new issue ? |
Fixes #424