Skip to content

Commit

Permalink
minor #5219 Fix contradicting merging policy rules (lscholten)
Browse files Browse the repository at this point in the history
This PR was merged into the 2.3 branch.

Discussion
----------

Fix contradicting merging policy rules

| Q                     | A
| ------------------ | ---
| Doc fix?           | yes
| New docs?      | no
| Applies to        | 2.3+
| Fixed tickets    | #5148

I've removed "a few minutes for typos or minor changes" from the first rule, fixing the contradiction and the redundancy.
I've also reordered the rules to remove "regardless of the number of votes" from the minor change rule.

Commits
-------

da57e09 Fix contradicting merge policy rules
  • Loading branch information
wouterj committed May 10, 2015
2 parents 4b04a37 + da57e09 commit a9445c9
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions contributing/code/core_team.rst
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,10 @@ Pull Request Merging Policy

A pull request **can be merged** if:

* Enough time was given for peer reviews (a few minutes for typos or minor
changes, at least 2 days for "regular" pull requests, and 4 days for pull
requests with "a significant impact");
* It is a minor change [1]_;

* It is a minor change [1]_, regardless of the number of votes;
* Enough time was given for peer reviews (at least 2 days for "regular"
pull requests, and 4 days for pull requests with "a significant impact");

* At least the component's **Merger** or two other Core members voted ``+1``
and no Core member voted ``-1``.
Expand Down

0 comments on commit a9445c9

Please sign in to comment.