Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doctrine] the reverse-engineering features are deprecated #16903

Closed
stof opened this issue Jun 20, 2022 · 3 comments
Closed

[Doctrine] the reverse-engineering features are deprecated #16903

stof opened this issue Jun 20, 2022 · 3 comments
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue.

Comments

@stof
Copy link
Member

stof commented Jun 20, 2022

https://symfony.com/doc/current/doctrine/reverse_engineering.html is documenting how to reverse-engineer entities from an existing database. However, this feature of doctrine/orm is deprecated and won't be improved anymore. This should at least be warned on the page, and maybe symfony.com should remove that page entirely.
@javiereguiluz
Copy link
Member

Do you know the Doctrine version that deprecated this? Or any other official resource from Doctrine confirming that it's deprecated? Thanks! (I can't see that it's deprecated in the Doctrine docs).

@wouterj
Copy link
Member

wouterj commented Jun 28, 2022

Yes: doctrine/DoctrineBundle#1082

Imho, we should just remove the page entirely

@javiereguiluz javiereguiluz mentioned this issue Jun 28, 2022
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jun 29, 2022
xabbuh added a commit that referenced this issue Jul 1, 2022
@xabbuh
minor #16924 [Doctrine] Deprecate the reverse engineering docs (javie…
47f3632 
…reguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

[Doctrine] Deprecate the reverse engineering docs

Fixes #16903.

Commits
-------

9ed3b06 [Doctrine] Deprecate the reverse engineering docs
@javiereguiluz
Copy link
Member

Closing as fixed in #16924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @stof @wouterj @xabbuh @carsonbot