Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for 'language' form type misleading #4251

Closed
cblegare opened this issue Sep 18, 2014 · 2 comments
Closed

Documentation for 'language' form type misleading #4251

cblegare opened this issue Sep 18, 2014 · 2 comments

Comments

@cblegare
Copy link

As stated in this documentation page

The "value" for each language is the Unicode language identifier (e.g. fr or zh-Hant).

which is wrong. Symfony uses some custom standard using underscores, not dashes, for languages.
@xabbuh xabbuh mentioned this issue Sep 19, 2014
Closed
@cblegare
Copy link
Author

IMO, this is not a documentation issue. This is only my opinion ;)

@stof
Copy link
Member

stof commented Sep 25, 2014

Well, the issue is that the documentation is wrong currently. It does not document the actual behavior of the code, while it should

This was referenced Oct 2, 2014
Closed
Merged
weaverryan added a commit that referenced this issue Oct 3, 2014
@weaverryan
bug #4284 change misleading language identifier (Kristof Van Cauwenbe…
9591a04 
…rgh, kristofvc)

This PR was merged into the 2.3 branch.

Discussion
----------

change misleading language identifier

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets | #4251

Commits
-------

db85c67 formatting to follow 72 characters line limit
12cccc8 changed dash to underscore
d68cd09 change misleading language identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @stof @cblegare