Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WCM] [Cookbook] [Security] Change the interface which needs to be implemented by a user repository #4543

Closed
mtrojanowski opened this issue Nov 29, 2014 · 2 comments
Closed

[WCM] [Cookbook] [Security] Change the interface which needs to be implemented by a user repository #4543

mtrojanowski opened this issue Nov 29, 2014 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security

Comments

@mtrojanowski
Copy link
Contributor

The symfony ticket: symfony/symfony#12733

If the code is merged, in this artice http://symfony.com/doc/current/cookbook/security/entity_provider.html#authenticating-someone-with-a-custom-entity-provider the interface used by the repository should be changed to the new interface and the supportsClass function can be deleted from the implementation.
@mtrojanowski mtrojanowski mentioned this issue Nov 29, 2014
Closed
@xabbuh xabbuh added Security good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Dec 9, 2014
@wouterj wouterj added Security actionable Clear and specific issues ready for anyone to take them. and removed Security good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Dec 17, 2014
@mtrojanowski mtrojanowski mentioned this issue Sep 27, 2015
Closed
@mtrojanowski
Copy link
Contributor Author

This is now connected to the PR #15947, which introduces slightly different changes. Nevertheless it will need a fix in the docs if the PR is accepted so please keep this issue open.

@xabbuh xabbuh added the On hold label Sep 30, 2015
fabpot added a commit to symfony/symfony that referenced this issue Oct 16, 2015
@fabpot
feature #15947 Added UserLoaderInterface for loading users through Do…
f19a7c9 
…ctrine. (mtrojanowski)

This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #15947).

Discussion
----------

Added UserLoaderInterface for loading users through Doctrine.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #11157
| License       | MIT
| Doc PR        | symfony/symfony-docs#4543

Based on the @weaverryan and @stof propositions from [this](#12733 (comment)) discussion I created a new interface in the Doctrine Bridge which can be used to more easily implement a repository capable of returning a User.

Commits
-------

a8d3d12 Added UserLoaderInterface for loading users through Doctrine.
@wouterj
Copy link
Member

wouterj commented Dec 20, 2015

Will be fixed by #5993

@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Dec 20, 2015
@xabbuh xabbuh removed the On hold label Dec 23, 2015
@wouterj wouterj closed this as completed Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wouterj @xabbuh @mtrojanowski