Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing constraint parameter in url #5802

Closed
poolerMF opened this issue Oct 17, 2015 · 1 comment
Closed

missing constraint parameter in url #5802

poolerMF opened this issue Oct 17, 2015 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Validator
Milestone
2.7

Comments

@poolerMF
Copy link

http://symfony.com/doc/current/reference/constraints/Url.html

-> missing parameter dnsMessage
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Validator labels Oct 18, 2015
@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

Thank you for reporting this @poolerMF.

For anyone wanting to work on this: Changes should be applied on the 2.7 branch. The dnsMessage option was introduced in symfony/symfony#12956 together with the checkDns option and controls the message that will be shown in case the DNS check failed.

@xabbuh xabbuh added this to the 2.7 milestone Oct 18, 2015
@BenjaminPaap BenjaminPaap mentioned this issue Oct 18, 2015
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 18, 2015
weaverryan added a commit that referenced this issue Nov 5, 2015
@weaverryan
feature #5804 Added documentation for dnsMessage option (BenjaminPaap)
5494f15 
This PR was merged into the 2.7 branch.

Discussion
----------

Added documentation for dnsMessage option

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7
| Fixed tickets | #5802

Commits
-------

e67beb2 Added missing comma after array element
368576b Fixed Yaml syntax
bffb90d Fixed all comments from @xabbuh
4cc4bae Added documentation for dnsMessage option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
3 participants
@weaverryan @xabbuh @poolerMF