Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cookbook] Don't explicitly create a Session instance #5844

Closed
xabbuh opened this issue Oct 27, 2015 · 0 comments
Closed

[Cookbook] Don't explicitly create a Session instance #5844

xabbuh opened this issue Oct 27, 2015 · 0 comments
Labels
HttpFoundation

Comments

@xabbuh
Copy link
Member

xabbuh commented Oct 27, 2015

In http://symfony.com/doc/current/cookbook/session/proxy_examples.html, we start the article with manually creating a Session instance. We should avoid this code examples as it isn't the way you use the session when using the complete framework (it already caused some confusion).
@javiereguiluz javiereguiluz mentioned this issue Nov 17, 2015
Closed
wouterj added a commit that referenced this issue Jul 2, 2016
@wouterj
minor #5892 Updated the session proxy article (javiereguiluz)
fc4a4e6 
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #5892).

Discussion
----------

Updated the session proxy article

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5844

I'm not sure if this is what @xabbuh was talking about in the related issue.

Commits
-------

a09d1f2 Updated the session proxy article
@wouterj wouterj closed this as completed Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wouterj @xabbuh