Replace Route annotations with attributes, remove Route annotation configuration block #17142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
force-pushed
the
feature/route-attributes
branch
from
061ee08 to
f8eb8bd
Compare
…nfiguration block
ker0x
force-pushed
the
feature/route-attributes
branch
from
f8eb8bd to
695332c
Compare
|
Romain, thanks a lot for this nice and big contribution! As you said, we prefer separate PRs for each removed annotation because this will introduce many merge conflicts, so it's better to work step by step. Thanks! |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 11, 2022
…RM annotation configuration block (ker0x) This PR was merged into the 6.0 branch. Discussion ---------- Replace ORM annotations with attributes, remove ORM annotation configuration block Following symfony#17142, this one replace all ORM annotations! Commits ------- 55da07f Replace ORM annotations with attributes, remove ORM annotation configuration block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16877, this PR replaces all
@Routeannotations with#[Route]attributes.It also remove Route annotation configuration block.
I only replaced the
@Routeannotations to simplify the review and get some initial feedback. Depending on them, I will adjust the changes and submit other PR to replace the other type of annotations if it's ok for you!