Fix the "doctrine file uploads" cookbook examples, see symfony/symfony-d... #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->file = $file; | ||
| // check if we have an old image path | ||
| if (is_file($this->getAbsolutePath())) { | ||
| //store the old name to delete after the update |
|
Thanks again @wouterj |
|
@mahmouds you're welcome. You should end short descriptions in PHPdoc comment with a |
|
Related issue #600 |
|
When using the id, in |
|
@winzou thanks for the tip I have just updated the PR. |
1 task
|
Hi Mahmoud! This has been merged in - I think that handling the "delete" is important. As you know, this whole document still needs to be heavily redone, which I've outlined in #2346. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a rename on "filenameForRemove" to "temp" as it holds only the extension of the file in the "Using the id as the filename" section but I am ok with any other suggestions.