Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3276] Trying to further clarify the session storage directory details #3404

Merged
merged 2 commits into from
Jan 21, 2014

Conversation

weaverryan
Copy link
Member

Hi guys!

This continues after #3342. Basically, it's confusing the symfony/symfony has a different default than the Symfony SE. However, I agree with Wouter that most framework readers are probably SE users. My strategy is simply to show people which configuration causes which situation.

Q A
Doc fix? yes
New docs? no
Applies to all (or 2.3+)
Fixed tickets #3276

Thanks!

http://symfony.com/schema/dic/symfony/symfony-1.0.xsd"
>
<framework:config>
<framework:session handler-id="null" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing

weaverryan added a commit that referenced this pull request Jan 21, 2014
…ectory details (weaverryan)

This PR was merged into the 2.3 branch.

Discussion
----------

[#3276] Trying to further clarify the session storage directory details

Hi guys!

This continues after #3342. Basically, it's confusing the symfony/symfony has a different default than the Symfony SE. However, I agree with Wouter that most framework readers are probably SE users. My strategy is simply to show people which configuration causes which situation.

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all (or 2.3+)
| Fixed tickets | #3276

Thanks!

Commits
-------

adc57be [#3404] Adding a few comments, per @wouterj
f094237 [#3276] Trying to further clarify the session storage directory details
@weaverryan weaverryan merged commit adc57be into 2.3 Jan 21, 2014
@weaverryan weaverryan deleted the session_storage_clarification branch January 21, 2014 02:37
@weaverryan
Copy link
Member Author

Hey guys!

I've merged this. Obviously, I feel like it explains it well, but we have some differences in opinion, and we really didn't hear the opinion from that many people (so I'm certainly happy to change things if others find this not great or want to improve it further). To be constructive, I think that should be done on a new PR with any new proposed changes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants