-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cookbook][Bundles] improve explanation of code block for bundle removal #3413
[Cookbook][Bundles] improve explanation of code block for bundle removal #3413
Conversation
@@ -96,8 +96,8 @@ rely on the bundle you are about to remove. | |||
.. tip:: | |||
|
|||
If one bundle relies on another, in most it means that it uses some services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, we have a typo here as well (in most cases it means
). Could you possibly add that to your PR (even though it wasn't your mistake)?
Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i did not see this, I am in Salt Lake City, Utah now so this escaped me else I would have fixed it, sorry @weaverryan
Thanks Luis! |
… bundle removal (cordoval) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Bundles] improve explanation of code block for bundle removal | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #3384 | | License | CC-ASA 3.0 Unported | Sent using [manager-tools](https://github.com/cordoval/manager-tools) Commits ------- a4d804d improve explanation of code block for bundle removal and fix typo
we gotta get you close PRs with Gush @weaverryan 👶 just |
@cordoval sorry, we choosed to use gh for the docs :) And please, please stop with advertising of your tool. It becomes annoying... |
in that case cool, I did not know it first hand from @weaverryan, thanks for the info @wouterj |
Sent using Gush