Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the indentation of two code blocks #3925

Merged
merged 1 commit into from
Jun 10, 2014
Merged

Fixed the indentation of two code blocks #3925

merged 1 commit into from
Jun 10, 2014

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets -

@xabbuh
Copy link
Member

xabbuh commented Jun 10, 2014

👍

@wouterj
Copy link
Member

wouterj commented Jun 10, 2014

Nice!

How do you catch all those errors? Do you just read every page and fix the wrong things, or do you use automated scripts, etc? (Just curious, since you're the best error-catching doc guy we've had :P)

@javiereguiluz
Copy link
Member Author

@wouterj thanks! The explanation is really simple: since we're redesigning the symfony.com website, whenever we introduce lots of changes in the styles, I randomly click on some documentation pages. Thanks to the new blockquote styles, when a code block is wrongly indented, it stands out very clearly and it's easy to spot it. So everything is about random luck.

@weaverryan
Copy link
Member

Cool! :)

@weaverryan weaverryan merged commit c8dbda9 into symfony:2.3 Jun 10, 2014
weaverryan added a commit that referenced this pull request Jun 10, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fixed the indentation of two code blocks

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | -

Commits
-------

c8dbda9 Fixed the indentation of two code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants