-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed references to documentation from external sources #4106
Conversation
@fabpot Can we then also remove the |
@xabbuh Correct, I was not aware of these files. Fixed now. |
@fabpot And one other thing: How do we handle |
Awesome! I can't wait for this to be merged. |
The step "(Optionally) Install the bundle docs and CMF docs: bash install.sh;" should also be removed from http://symfony.com/doc/current/contributing/documentation/format.html#testing-documentation |
@wouterj done |
@fabpot I created a PR which removes even more references to third party docs: fabpot#1 And do these entries in the redirection map still work?
|
* :doc:`/bundles/DoctrineFixturesBundle/index` | ||
* :doc:`/bundles/DoctrineMongoDBBundle/index` | ||
* :doc:`DoctrineFixturesBundle` | ||
* :doc:`DoctrineMongoDBBundle` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, my fault: The :doc:
prefix should be removed and they both have to be suffixed with _
3846bd9
to
c39ea1d
Compare
a2131be
to
2cb8d27
Compare
merging now! |
… (fabpot, WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- removed references to documentation from external sources | Q | A | ------------- | --- | Doc fix? | n/a | New docs? | n/a | Applies to | all | Fixed tickets | n/a Referencing external doc sources was a mistake as the versioning can be (and is) different from the versioning of the Symfony docs. **WARNING** I will merge this one myself to coordinate the merge with the release of the new frontend on symfony.com. Commits ------- 2cb8d27 removed more references to documentation from external sources c39ea1d Removed more references to third party docs 0e2c491 removed references to documentation from external sources
The website has been updated now. As you can see for yourself, each bundle and the Symfony CMF have their own versions now. It took a lot of time to get there, and I'm very happy to have finished this one. The code has been drastically changed so hopefully, I don't have introduced too many regressions. |
Referencing external doc sources was a mistake as the versioning can be (and is) different from the versioning of the Symfony docs.
WARNING I will merge this one myself to coordinate the merge with the release of the new frontend on symfony.com.